Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Make a copy of azure pipeline definition files in new locations #7233

Merged
merged 3 commits into from Feb 27, 2023
Merged

[MAINTENANCE] Make a copy of azure pipeline definition files in new locations #7233

merged 3 commits into from Feb 27, 2023

Conversation

anthonyburdi
Copy link
Member

@anthonyburdi anthonyburdi commented Feb 24, 2023 •
edited

Changes proposed in this pull request:

  • Make a copy of azure pipeline definition files in new locations (existing files will be deleted after changing azure to reference the new locations)
  • Stub README file describing the folder and contents.

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@netlify
Copy link

netlify bot commented Feb 24, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 057b3bd
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63fcfdafda39c300089e1625

@anthonyburdi anthonyburdi changed the title Make a copy of azure pipeline definition files in new locations [MAINTENANCE] Make a copy of azure pipeline definition files in new locations Feb 24, 2023
@anthonyburdi anthonyburdi self-assigned this Feb 24, 2023
@anthonyburdi anthonyburdi requested review from a team February 24, 2023 23:40
@ghost
Copy link

ghost commented Feb 24, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

cdkini
cdkini reviewed Feb 27, 2023
View reviewed changes
ci/README.md
@@ -0,0 +1,3 @@
# Continuous Integration Tests

This folder contains pipeline configurations and any ancillary files needed for our Continuous Integration test pipelines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow this description up with details about each pipeline? Maybe copying from that Confluence doc? Not necessary here but might be helpful for future devs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree. Let's do that in a follow up PR e.g. when I'm removing the files copied in this PR just so we can get this cleanup process started.

@anthonyburdi anthonyburdi merged commit 4334201 into develop Feb 27, 2023
@anthonyburdi anthonyburdi deleted the m/dx-153/create_ci_folder branch February 27, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdkini cdkini cdkini approved these changes

Assignees

@anthonyburdi anthonyburdi

Labels
core-team dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonyburdi @cdkini